Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't allow empty quote #377

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

Pushkarm029
Copy link
Contributor

Fixes [BUG] don't allow empty quote

**My PR closes #356 **

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Added a Hook to Store the message in which we want to reply.
  • Fixed some indentation.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

@vercel
Copy link

vercel bot commented Oct 5, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

@Pushkarm029
Copy link
Contributor Author

@Dun-sin please review

client/src/components/Chat.jsx Outdated Show resolved Hide resolved
@Pushkarm029
Copy link
Contributor Author

@Dun-sin done

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 5, 2023 10:25am

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit ae221c8 into Dun-sin:main Oct 5, 2023
1 check passed
@Pushkarm029
Copy link
Contributor Author

@Dun-sin thank you so much

@Pushkarm029 Pushkarm029 deleted the fix_empty_quote_bug branch February 7, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] don't allow empty quote
2 participants