Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Age Validation in Profile Section #411

Merged
merged 3 commits into from
Oct 15, 2023

Conversation

varundhand
Copy link
Contributor

Fixes Issue #410

My PR closes #410

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

I have implemented client-side validation to prevent users from entering negative values for age. This was achieved by using HTML attributes and JavaScript validation.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

Could you please consider adding the "hacktoberfest" and "hacktoberfest-accepted" labels to this pr? Thanks a bunch!

πŸ“· Screenshots

whisper.mov

@vercel
Copy link

vercel bot commented Oct 13, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@varundhand varundhand changed the title Add: Age Validation in Profile Section fix: Age Validation in Profile Section Oct 13, 2023
@varundhand
Copy link
Contributor Author

@Dun-sin ready for review

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 14, 2023

@Dun-sin ready for review

Please don't tag maintainers for a review, we see the PR you create. Will attend to you when we can

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit 1f586e2 into Dun-sin:main Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Age Validation in Profile Section
2 participants