feat: Dynamic imports BadWordsNext Chat #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel. @Dun-sin first needs to authorize it. |
Dun-sin
requested changes
Jan 23, 2024
Dun-sin
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Alright, looks good
You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.
Consider giving this project a star and joining the community discord server if you haven't for more resources and opportunities to connect with others. 👉🏽here👈🏽
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Dun-sin
pushed a commit
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
My PR closes #593
👨💻 Changes proposed(What did you do ?)
I created a function called getBadwords, which imports BadWordsNext and EN only when handleSubmit is triggered. Additionally, I introduced a new component called BadwordHideShow, as it also utilizes badword and needed to be externalized.
✔️ Check List (Check all the applicable boxes)
Note to reviewers
This already enhances performance to some extent. However, I believe we can further modularize the chat section, enabling us to identify more performance optimization opportunities.
📷 Screenshots