-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow users to close a chat on the home screen #681
feat: allow users to close a chat on the home screen #681
Conversation
@kartik-raj7 is attempting to deploy a commit to the dunsin's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Your PR doesn't solve the issue, please read the issue description carefully and fix your PR as needed |
Could you please elaborate the issue a bit, that would be really helpful Do I need to create a button which gives option to close the chat on homepage next to open chat? |
That's what the issue says |
@kartik-raj7 are you still interested in this? |
Yes I am, will do the necessary changes |
@kartik-raj7 you have 4 more days |
My PR closes #677
π¨βπ» Changes proposed(What did you do ?)
Updated the useEffect hook in the Start.jsx file to check if the app has a currentChatId key. If it does, the user is now automatically redirected to the chat page, removing the need to manually open the chat. Consequently, I've removed the conditional display of the "Open Chat" and "Start" options in the Link, as the app now handles the redirection based on the presence of currentChatId key in app object.
βοΈ Check List (Check all the applicable boxes)
Note to reviewers
π· Screenshots