Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow users to close a chat on the home screen #681

Closed

Conversation

kartik-raj7
Copy link

My PR closes #677

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

Updated the useEffect hook in the Start.jsx file to check if the app has a currentChatId key. If it does, the user is now automatically redirected to the chat page, removing the need to manually open the chat. Consequently, I've removed the conditional display of the "Open Chat" and "Start" options in the Link, as the app now handles the redirection based on the presence of currentChatId key in app object.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

Copy link

vercel bot commented Aug 21, 2024

@kartik-raj7 is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@kartik-raj7 kartik-raj7 changed the title [FEATURE] allow users to close a chat on the home screen #677 [FEAT] allow users to close a chat on the home screen #677 Aug 21, 2024
@kartik-raj7 kartik-raj7 changed the title [FEAT] allow users to close a chat on the home screen #677 [FEAT] allow users to close a chat on the home screen Aug 21, 2024
@kartik-raj7 kartik-raj7 changed the title [FEAT] allow users to close a chat on the home screen feat: allow users to close a chat on the home screen Aug 21, 2024
@Dun-sin
Copy link
Owner

Dun-sin commented Aug 21, 2024

Your PR doesn't solve the issue, please read the issue description carefully and fix your PR as needed

@kartik-raj7
Copy link
Author

kartik-raj7 commented Aug 21, 2024

Your PR doesn't solve the issue, please read the issue description carefully and fix your PR as needed

Could you please elaborate the issue a bit, that would be really helpful

Do I need to create a button which gives option to close the chat on homepage next to open chat?

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 21, 2024

Your PR doesn't solve the issue, please read the issue description carefully and fix your PR as needed

Could you please elaborate the issue a bit, that would be really helpful

Do I need to create a button which gives option to close the chat on homepage next to open chat?

That's what the issue says

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 24, 2024

@kartik-raj7 are you still interested in this?

@kartik-raj7
Copy link
Author

@kartik-raj7 are you still interested in this?

Yes I am, will do the necessary changes

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 27, 2024

@kartik-raj7 you have 4 more days

@Dun-sin Dun-sin closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] allow users to close a chat on the home screen
2 participants