-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add window and light binary sensors #38
Conversation
🎉 HACS repository validator action summary 🎉 |
Got error at initial restart. I had this previously too, so not likely related to this release, but maybe worth looking at. It resolves when removing the integration and install again (it´ll generate same sensors) Logger: homeassistant.config_entries Error setting up entry renewoensdregt@hotmail.com for toyota
Rest of install has gone fine and new sensors are generated. Will need to open the windows later today to see if all works as planned! |
@renewoensdregt Can I get you to open a separate issue for the install problem? So I can track separately 😊 And great to hear!! Looking forward to an update |
The integration has an update interval set at 5 minutes, this was because before it wasn't really necessary to update often, but this my change that. I will change it to 1 minute, but let us test it for a couple of days, just so we are sure it is not causing other problems |
Yes, let´s continue (I´ll likely do some more testing this weekend as I hardly use the car during the week), as I am not necessarily sure the issue is the timing of the polling of your module to the MyToyota, but it might even be MyToyota that doesn't poll the car very frequently. In that case increasing your polling won´t really help. |
I just pushed an update to here that reduces the update interval to 90 seconds instead of 5 minutes. |
Now you should also get 3 sensors, one for headlights(front), backlights and hazard lights 🎉 |
confirmed! new update pulls those in. Will do some further testing as said during the weekend! |
a64ed27
to
2f463c9
Compare
Been testing various combinations and all work well!!! The only thing I’ve noticed is that doors unlocked is not yet showing in your code and that it’s takes time for the updates to see, even in the MyT it takes time. Not sure how to test the lights… |
I have not added doors yet. Taking one thing at a time. Will add them in a separate PR in the next couple of days 😊 If your hazard lights are turned on the sensor should show they are on and vice versa 😊 |
Tested hazards and works!! Light detected 😁 |
Awesome!! I am also gonna introduce a overall warning sensor in the next PR along with the doors, hood and tailgate😄 AND i may have a surprise for you all. Being able to lock and unlock the car from HA, but i will need you guys to test it 🤞 |
👏👏👏 did you see the PR for Dutch? Just asking as I’m not sure I did all right. |
@renewoensdregt there is no PR open on here, did you open it on your own fork by accident? 🤔 |
Told you I was no expert :-) but I’ll create a new one tomorrow if needed. |
Haha that's totally okay, we all have to learn 😄 You need to open the PR against my repository like you did with the first one, or else i can't include it. |
2f463c9
to
d11379d
Compare
Let me try as indeed need to learn how to do it correctly. noticed you picked up the others quickly but this one not, hence why I wondered. |
Github can have a steep learning curve when you start using it, it took me a couple of months before i got comfortable with it. So just take your time and ask (As you already do) and i will guide you as best as i can 😃 |
No description provided.