Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring #221

Closed
wants to merge 8 commits into from
Closed

Conversation

CM000n
Copy link
Collaborator

@CM000n CM000n commented Mar 3, 2023

No description provided.

@CM000n CM000n marked this pull request as draft March 3, 2023 10:30
@DurgNomis-drol
Copy link
Owner

Beware that the HA integration uses the old the legacy version 0.7.8, so you will need to upgrade the HA integration to use these changes (0.91 -> and forward)

But else, awesome job! 🚀

@CM000n
Copy link
Collaborator Author

CM000n commented Mar 6, 2023

Beware that the HA integration uses the old the legacy version 0.7.8, so you will need to upgrade the HA integration to use these changes (0.91 -> and forward)

But else, awesome job! 🚀

Ok, let's roll back the change with my poetry fix in ha_toyota then. Because there, the dependency now also refers to the PyPI 0.9.1 package. This of course explains my question from here, if there were breaking changes between 0.7.x and 0.9.x. : DurgNomis-drol/ha_toyota#131 (comment)

@DurgNomis-drol
Copy link
Owner

I didn't spot you comment on that one, but yes that explains it 😃

@CM000n CM000n marked this pull request as ready for review March 7, 2023 09:10
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #221 (ddab520) into master (67eb598) will decrease coverage by 0.51%.
The diff coverage is 90.44%.

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   94.64%   94.13%   -0.51%     
==========================================
  Files          30       30              
  Lines        1605     1585      -20     
==========================================
- Hits         1519     1492      -27     
- Misses         86       93       +7     
Flag Coverage Δ
unittests 94.13% <90.44%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mytoyota/controller.py 35.89% <43.75%> (-0.39%) ⬇️
mytoyota/client.py 93.46% <86.27%> (-4.46%) ⬇️
mytoyota/models/dashboard.py 98.03% <95.83%> (-1.97%) ⬇️
mytoyota/api.py 100.00% <100.00%> (ø)
mytoyota/models/data.py 100.00% <100.00%> (ø)
mytoyota/models/hvac.py 100.00% <100.00%> (ø)
mytoyota/models/location.py 100.00% <100.00%> (ø)
mytoyota/models/lock_unlock.py 100.00% <100.00%> (+2.43%) ⬆️
mytoyota/models/sensors.py 100.00% <100.00%> (ø)
mytoyota/models/trip.py 98.14% <100.00%> (+4.92%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@DurgNomis-drol DurgNomis-drol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please see my comment

@CM000n CM000n closed this Nov 9, 2023
@CM000n CM000n changed the title Draft: Small refactoring Small refactoring Nov 27, 2023
@CM000n CM000n deleted the small_refactoring branch December 23, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants