-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small refactoring #221
Small refactoring #221
Conversation
Beware that the HA integration uses the old the legacy version 0.7.8, so you will need to upgrade the HA integration to use these changes (0.91 -> and forward) But else, awesome job! 🚀 |
Ok, let's roll back the change with my poetry fix in ha_toyota then. Because there, the dependency now also refers to the PyPI 0.9.1 package. This of course explains my question from here, if there were breaking changes between 0.7.x and 0.9.x. : DurgNomis-drol/ha_toyota#131 (comment) |
I didn't spot you comment on that one, but yes that explains it 😃 |
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
- Coverage 94.64% 94.13% -0.51%
==========================================
Files 30 30
Lines 1605 1585 -20
==========================================
- Hits 1519 1492 -27
- Misses 86 93 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please see my comment
No description provided.