Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when returning Unit #7

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Fix error when returning Unit #7

merged 2 commits into from
Feb 21, 2023

Conversation

Guldem
Copy link
Member

@Guldem Guldem commented Jul 15, 2022

Fixes #5

Returns null instead of Unit. Flutter MethodChannel doesn't support Kotlin Unit type.

@minhdanh
Copy link
Contributor

Hi @Guldem,
Is this PR ready to merge yet? I'm seeing the error in #5 too 😅

@Guldem Guldem merged commit 12af445 into master Feb 21, 2023
@Guldem Guldem deleted the fix/unit_parsing_error branch February 21, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bassiuz Bassiuz Bassiuz approved these changes

@NRijnberg NRijnberg Awaiting requested review from NRijnberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsupported value: 'kotlin.Unit' of type 'class kotlin.Unit'
3 participants
@Guldem @minhdanh @Bassiuz