Stateful Proposal doc #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszacillo
reviewed
Jul 1, 2024
| tolerationSeconds: 90 | ||
| purgeMode: Graciously | ||
| gracePeriodSeconds: 10 | ||
| persistedFields.maxHistory: 5 |
There was a problem hiding this comment.
Check indenting. This should align with gracePeriodSeconds - we should also consider how this mechanism works with taint-based eviction.
There was a problem hiding this comment.
Hmm not sure why it shows up differently here but will check:
I am planning on adding at the application level so that it can be used for both cluster and application failure
apiVersion: policy.karmada.io/v1alpha1
kind: PropagationPolicy
metadata:
name: flinkdep-policy
spec:
failover:
application:
decisionConditions:
tolerationSeconds: 90
purgeMode: Graciously
gracePeriodSeconds: 10
persistedFields.maxHistory: 5
persistedFields.fields:
- LabelName: jobID
PersistedStatusItem: obj.status.jobStatus.jobID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Proposal for stateful failover
What this PR does / why we need it:
Explained in the doc
Which issue(s) this PR fixes:
Fixes karmada-io#5006, karmada-io#4969
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?:
NONE