bug fix: cache failed when statement wasn't character class (DyfanJon…

…es/noctua#171)
DyfanJones · Nov 15, 2021 · 4cf7a12 · 4cf7a12
1 parent f8ef9d2
commit 4cf7a12
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,7 @@
 # RAthena (development version)
 ## Bug Fix:
-* Ensure `dbGetQuery`, `dbExecute`, `dbSendQuery`, `dbSendStatement` work on older versions of ([noctua # 170](https://github.com/DyfanJones/noctua/issues/170))
+* Ensure `dbGetQuery`, `dbExecute`, `dbSendQuery`, `dbSendStatement` work on older versions of `R` ([noctua # 170](https://github.com/DyfanJones/noctua/issues/170)). Thanks to @tyner for identifying issue.
+* Caching would fail when statement wasn't a character ([noctua # 171](https://github.com/DyfanJones/noctua/issues/171)). Thanks to @ramnathv for identifying issue.
 
 # RAthena 2.3.0
 ## Feature:

diff --git a/R/util.R b/R/util.R
@@ -219,7 +219,8 @@ cache_query = function(res){
   if(res@info$Status != "FAILED") {
     cache_append = data.table(
       "QueryId" = res@info[["QueryExecutionId"]],
-      "Query" = res@info[["Query"]],
+      # ensure query is character class when caching
+      "Query" = as.character(res@info[["Query"]]),
       "State"= res@info[["Status"]],
       "StatementType"= res@info[["StatementType"]],
       "WorkGroup" = res@info[["WorkGroup"]],