Merge pull request #172 from DyfanJones/cache_issue

Cache issue
DyfanJones · Nov 15, 2021 · d8d17b3 · d8d17b3
2 parents 4d313fa + 71cab8a
commit d8d17b3
Show file tree

Hide file tree

Showing 56 changed files with 818 additions and 793 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,4 +1,7 @@
 # noctua (development version)
+## Bug Fix:
+* Ensure `dbGetQuery`, `dbExecute`, `dbSendQuery`, `dbSendStatement` work on older versions of `R` (#170). Thanks to @tyner for identifying issue.
+* Caching would fail when statement wasn't a character (#171). Thanks to @ramnathv for identifying issue.
 
 # noctua 2.3.0
 ## Feature:

diff --git a/R/utils.R b/R/utils.R
@@ -252,7 +252,8 @@ cache_query = function(res){
   if(res@info$Status != "FAILED") {
     cache_append = data.table(
       "QueryId" = res@info[["QueryExecutionId"]],
-      "Query" = res@info[["Query"]],
+      # ensure query is character class when caching
+      "Query" = as.character(res@info[["Query"]]),
       "State"= res@info[["Status"]],
       "StatementType"= res@info[["StatementType"]],
       "WorkGroup" = res@info[["WorkGroup"]],

diff --git a/docs/404.html b/docs/404.html
diff --git a/docs/LICENSE-text.html b/docs/LICENSE-text.html
diff --git a/docs/articles/aws_athena_query_caching.html b/docs/articles/aws_athena_query_caching.html
diff --git a/docs/articles/aws_athena_unload.html b/docs/articles/aws_athena_unload.html
diff --git a/docs/articles/aws_s3_backend.html b/docs/articles/aws_s3_backend.html
diff --git a/docs/articles/changing_backend_file_parser.html b/docs/articles/changing_backend_file_parser.html
diff --git a/docs/articles/convert_and_save_cost.html b/docs/articles/convert_and_save_cost.html
diff --git a/docs/articles/getting_started.html b/docs/articles/getting_started.html
diff --git a/docs/articles/how_to_retry.html b/docs/articles/how_to_retry.html
diff --git a/docs/articles/index.html b/docs/articles/index.html
diff --git a/docs/authors.html b/docs/authors.html