Skip to content

Commit

Permalink
Rollup merge of rust-lang#79177 - fanzier:drop-order-test, r=RalfJung
Browse files Browse the repository at this point in the history
Test drop order for (destructuring) assignments

Add a test that checks whether the drop order of `let` bindings is consistent with the drop order of the corresponding destructuring assignments.

Thanks to ```@RalfJung``` for the suggesting this test ([here](rust-lang#79016 (comment))) and an implementation!

r? ```@RalfJung```
  • Loading branch information
Dylan-DPC committed Nov 19, 2020
2 parents c2a277c + 1094f97 commit acc2e23
Showing 1 changed file with 44 additions and 0 deletions.
44 changes: 44 additions & 0 deletions src/test/ui/destructuring-assignment/drop-order.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
// run-pass

//! Test that let bindings and destructuring assignments have consistent drop orders

#![feature(destructuring_assignment)]
#![allow(unused_variables, unused_assignments)]

use std::cell::RefCell;

thread_local! {
static DROP_ORDER: RefCell<Vec<usize>> = RefCell::new(Vec::new());
}

struct DropRecorder(usize);
impl Drop for DropRecorder {
fn drop(&mut self) {
DROP_ORDER.with(|d| d.borrow_mut().push(self.0));
}
}

fn main() {
let expected_drop_order = vec![1, 4, 5, 3, 2];
// Check the drop order for let bindings:
{
let _ = DropRecorder(1);
let _val = DropRecorder(2);
let (x, _) = (DropRecorder(3), DropRecorder(4));
drop(DropRecorder(5));
}
DROP_ORDER.with(|d| {
assert_eq!(&*d.borrow(), &expected_drop_order);
d.borrow_mut().clear();
});
// Check that the drop order for destructuring assignment is the same:
{
let _val;
let x;
_ = DropRecorder(1);
_val = DropRecorder(2);
(x, _) = (DropRecorder(3), DropRecorder(4));
drop(DropRecorder(5));
}
DROP_ORDER.with(|d| assert_eq!(&*d.borrow(), &expected_drop_order));
}

0 comments on commit acc2e23

Please sign in to comment.