Add onProgress and onComplete to preload.

[doomsower]

The title is pretty self-descriptive. Here is the feature request topic: #144

Hopefully will add Android counterpart on Saturday.

[doomsower]

Ok, now on Android too!

[doomsower]

#266

This can be easily added on JS side (e.g. when onProgress and onComplete are both undefined, make JS method return promise).
But first I want maintaineer to review this PR at least. Btw I already use this code in a small production app, no complaints and crashes so far.

[aaalive]

Hi
It's very useful, could you please merge?

[alirezarastegarfard]

how can i use this feature ?

[elan]

Any plans on getting this merged? Would be awesome to not have to fork the repo to use it 😅

[ChristianTucker]

Please get this merged.

@retyui @DylanVann

[luco]

@DylanVann Merge this please.

[xzilja]

Is there anything preventing this PR from being merged @DylanVann ? Would love to help :)

[huang-xiao-jian]

Is there any plan for the PR?

[franciscomdelgado]

@DylanVann willing to resolve CI failure to get this merged into the package. Some guidance would be appreciated though.

[DylanVann]

Sorry for the lack of response. The reason I did not implement this feature, and the reason I'd be hesitant to merge this is that the API SDWebImage provides for prefetching images is not very good.

It does not tell you which images fail and succeed, it only gives you the number of successful loads and failed loads, which seems silly to me.

If someone did a PR to improve their API I'd be much more likely to merge something like this.

[franciscomdelgado]

Sorry for the lack of response. The reason I did not implement this feature, and the reason I'd be hesitant to merge this is that the API SDWebImage provides for prefetching images is not very good.

It does not tell you which images fail and succeed, it only gives you the number of successful loads and failed loads, which seems silly to me.

If someone did a PR to improve their API I'd be much more likely to merge something like this.

Awesome, I was wondering why it hadn't been merged; seems like a good feature. But that is a valid reason not to merge this feature.

[codecov]

Codecov Report

Merging #268 into master will decrease coverage by 38.3%.
The diff coverage is 34.48%.

@@             Coverage Diff             @@
##           master     #268       +/-   ##
===========================================
- Coverage   94.11%   55.81%   -38.31%     
===========================================
  Files           1        2        +1     
  Lines          17       43       +26     
===========================================
+ Hits           16       24        +8     
- Misses          1       19       +18

Impacted Files	Coverage Δ
src/preloaderManager.js	33.33% <33.33%> (ø)
src/index.js	93.75% <50%> (-0.37%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8c0c8...1a395c1. Read the comment docs.

[doomsower]

@DylanVann and everyone interested

I've update this PR. Now iOS progress handler checks if the url it receives is cached on disk. Based on this JS callbacks will now return array of cached urls as first argument.

I also merged master, so it's up to date with v7 of this module, and I updated example project to RN 0.60.5. Example project works fine on iOS and Android. However, I haven't tried this in a real project, as I have yet to migrate my app that utilizes preloading to RN 0.60

[DylanVann]

Closing this until we can resolve the blocking issue of SDWebImage not giving enough info.

I wrote a roadmap.md file to keep track of this kind of thing, with a link to this PR.

https://github.com/DylanVann/react-native-fast-image/blob/master/docs/roadmap.md#add-onprogress-and-oncomplete-to-preload