Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FastImage.cache properties in TypeScript types. #348

Merged
merged 1 commit into from
Dec 31, 2018

Conversation

keima
Copy link

@keima keima commented Nov 16, 2018

Hi,
I love this lib.
I occurred compile error following:

node_modules/react-native-fast-image/src/index.d.ts:129:30 - error TS2694: Namespace 'FastImage' has no exported member 'cache'.

129         cacheOnly: FastImage.cache.cacheOnly
                                 ~~~~~

node_modules/react-native-fast-image/src/index.d.ts:130:30 - error TS2694: Namespace 'FastImage' has no exported member 'cache'.

130         immutable: FastImage.cache.immutable
                                 ~~~~~

node_modules/react-native-fast-image/src/index.d.ts:131:24 - error TS2694: Namespace 'FastImage' has no exported member 'cache'.

131         web: FastImage.cache.web
                           ~~~~~

So I had written this patch. Thanks.

@DylanVann
Copy link
Owner

Looks great, thank you!

@DylanVann DylanVann changed the base branch from master to fix-types December 31, 2018 02:02
@DylanVann DylanVann merged commit b4fe8d2 into DylanVann:fix-types Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants