Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add caching management #544

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add caching management #544

wants to merge 4 commits into from

Conversation

bpouzet
Copy link

@bpouzet bpouzet commented Aug 21, 2019

retry guhundry pull request #425 with latest version of fastimage

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #544 into master will decrease coverage by 8.4%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
- Coverage   94.11%   85.71%   -8.41%     
==========================================
  Files           1        1              
  Lines          17       21       +4     
==========================================
+ Hits           16       18       +2     
- Misses          1        3       +2
Impacted Files Coverage Δ
src/index.js 85.71% <50%> (-8.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8c0c8...a96335f. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #544 into master will decrease coverage by 8.4%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
- Coverage   94.11%   85.71%   -8.41%     
==========================================
  Files           1        1              
  Lines          17       21       +4     
==========================================
+ Hits           16       18       +2     
- Misses          1        3       +2
Impacted Files Coverage Δ
src/index.js 85.71% <50%> (-8.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b8c0c8...8c16756. Read the comment docs.

@mrousavy
Copy link

@DylanVann could you please take a look at this PR? Clearing cache can be quite beneficial 😬

}

export interface PreloadCompletionHandler {
(loaded: number, skipped: number): void
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should be able to tell the status of individual images with these callbacks. I think SDWebImage might support this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants