-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add caching management #544
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
- Coverage 94.11% 85.71% -8.41%
==========================================
Files 1 1
Lines 17 21 +4
==========================================
+ Hits 16 18 +2
- Misses 1 3 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
==========================================
- Coverage 94.11% 85.71% -8.41%
==========================================
Files 1 1
Lines 17 21 +4
==========================================
+ Hits 16 18 +2
- Misses 1 3 +2
Continue to review full report at Codecov.
|
@DylanVann could you please take a look at this PR? Clearing cache can be quite beneficial 😬 |
} | ||
|
||
export interface PreloadCompletionHandler { | ||
(loaded: number, skipped: number): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we should be able to tell the status of individual images with these callbacks. I think SDWebImage might support this now.
retry guhundry pull request #425 with latest version of fastimage