add dotnet 8 to kirkstone #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Fekih, Hichem <hichem.benfekih@ifm.com>
…provider.so it seams that dotnet 8 doesn't produce libcoreclrtraceptprovider.so for the helloworld application anymore. so suppress the error by adding "-f". when dotnet 6 and 7 reach EOF, then we can remove this line. Signed-off-by: Ben Fekih, Hichem <hichem.benfekih@ifm.com>
since this is not a self-contained application, dotnet must be available on target. For some reason it was working fine with dotnet 6, but event though the dotnet runtime must be installed.
|
Awesome 🙌 |
|
@ajlennon should we merge this PR? if someone is using the kirkstone branch and using dotnet 6, then he will get a free/unintentional upgrade to dotnet 8 😄 . this can be |
|
Sounds good to me - to you want to remove draft status then? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just testing if the kirkstone branch is working fine. (since this is the only version I am using right now)