Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drmodtrack offset field has uninitialized values on Windows #4777

Closed
derekbruening opened this issue Mar 10, 2021 · 0 comments · Fixed by #4778
Closed

drmodtrack offset field has uninitialized values on Windows #4777

derekbruening opened this issue Mar 10, 2021 · 0 comments · Fixed by #4778
Assignees
@derekbruening

Comments

@derekbruening
Copy link
Contributor

For #2939 an offset field was added to drmodtrack in PR #2940 (and PR #2973). However, it is ifdef-ed out for Windows in some places but not in others. Now, I'm adding a new field for #4474, and drmodtrack-test is failing with uninit bogus printed offset values differing bet online and offline. Not sure how it passed before: probably just got lucky and the uninit values matched.

It's too late to ifdef it out of the interface so maybe the best solution is to set it to 0 on Windows.
@derekbruening derekbruening mentioned this issue Mar 10, 2021
Merged
@derekbruening derekbruening self-assigned this Mar 10, 2021
derekbruening added a commit that referenced this issue Mar 10, 2021
@derekbruening
i#4777: Fix uninitialized drmodtrack offset on Windows
324d4dc 
PR #2940 and #2973 added an offset field to drmodtrack for #2939, but
they ifdef-ed the field in some places but not others, resulting in
uninitialized output.  Since it's already locked into the interface,
we always set it to 0 here and include it in internal structures to
fix the problem.

Tested on drmodtrack-test where the fields were manually confirmed to
no longer contain bogus values, and where the test doesn't fail when
that masked this bug before.

Issue: #2939, #4474, #4777
Fixes #4777
@derekbruening derekbruening mentioned this issue Mar 10, 2021
Merged
derekbruening added a commit that referenced this issue Mar 10, 2021
@derekbruening
i#4777: Fix uninitialized drmodtrack offset on Windows (#4778)
e655189 
PR #2940 and #2973 added an offset field to drmodtrack for #2939, but
they ifdef-ed the field in some places but not others, resulting in
uninitialized output.  Since it's already locked into the interface,
we always set it to 0 here and include it in internal structures to
fix the problem.

Tested on drmodtrack-test where the fields were manually confirmed to
no longer contain bogus values, and where the test doesn't fail when
that masked this bug before.

Issue: #2939, #4474, #4777
Fixes #4777
derekbruening added a commit that referenced this issue Mar 10, 2021
@derekbruening
i#4777: Fix uninitialized drmodtrack offset on Windows
8e26342 
PR #2940 and #2973 added an offset field to drmodtrack for #2939, but
they ifdef-ed the field in some places but not others, resulting in
uninitialized output.  Since it's already locked into the interface,
we always set it to 0 here and include it in internal structures to
fix the problem.

Tested on drmodtrack-test where the fields were manually confirmed to
no longer contain bogus values, and where the test doesn't fail when
i#4474 adds a new field that shifts the test buffer to avoid the
happens-to-match scenario that masked this bug in that test before.

Issue: #2939, #4474, #4777
Fixes #4777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbruening derekbruening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#4777: Fix uninitialized drmodtrack offset on Windows DynamoRIO/dynamorio
1 participant
@derekbruening