Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise mcontext init by avoiding excessive zeroing. #4499

Merged
merged 3 commits into from
Oct 30, 2020
Merged

Optimise mcontext init by avoiding excessive zeroing. #4499

merged 3 commits into from
Oct 30, 2020

Conversation

abhinav92003
Copy link
Contributor

Instead of using partial struct initialisation, simply initialise the required fields.

@abhinav92003
iX: Optimise mcontext init by avoiding excessive zeroing.
3a92cdf 
Instead of using partial struct initialisation, simply initialise the required fields.
@abhinav92003 abhinav92003 mentioned this pull request Oct 29, 2020
Merged
derekbruening
derekbruening approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@derekbruening derekbruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup. We discovered the zeroing of the big struct was a perf hit a while back on Dr. Memory and somehow I thought we had already changed all our samples to set good examples.

api/samples/cbr.c Show resolved Hide resolved
api/samples/cbr.c Show resolved Hide resolved
@abhinav92003 abhinav92003 changed the title iX: Optimise mcontext init by avoiding excessive zeroing. Optimise mcontext init by avoiding excessive zeroing. Oct 30, 2020
@abhinav92003 abhinav92003 merged commit 7a5d3e1 into master Oct 30, 2020
@abhinav92003 abhinav92003 deleted the iX-optimise-mcontext-init branch October 30, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbruening derekbruening derekbruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhinav92003 @derekbruening