Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#3544 RV64: Implement TLS functions #6091

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Conversation

ksco
Copy link
Contributor

@ksco ksco commented May 27, 2023

This patch adds the implementation of RV64-specific TLS functions.

Issue: #3544

@ksco ksco requested a review from abhinav92003 May 27, 2023 09:32
Copy link
Contributor

@abhinav92003 abhinav92003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to get Derek's review too.

core/unix/os.c Show resolved Hide resolved
core/unix/tls_linux_riscv64.c Outdated Show resolved Hide resolved
core/unix/os.c Outdated Show resolved Hide resolved
core/unix/tls_linux_riscv64.c Outdated Show resolved Hide resolved
@ksco ksco requested a review from derekbruening June 8, 2023 02:30
@derekbruening derekbruening added this pull request to the merge queue Jun 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 9, 2023
@ksco ksco added this pull request to the merge queue Jun 9, 2023
@derekbruening
Copy link
Contributor

Hmm, we had a merge queue failure again? I looked at it and added it to #2204 (comment). Please add any observed merge queue failure to the same issue in the future if you encounter one so there is a list of still-flaky tests for someone to try to fix if someone has time in the future.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 9, 2023
@derekbruening derekbruening merged commit 96dca71 into DynamoRIO:master Jun 9, 2023
@ksco ksco deleted the tls branch June 23, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants