Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6831 sched refactor, step 3: Split pick_next_input() #7078

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

derekbruening
Copy link
Contributor

Splits the bulk of pick_next_input() into a new virtual method pick_next_input_try() which is implemented by new subclasses scheduler_{dynamic,fixed,replay}.cpp.
Moves pick_next_input_as_previously() into the _replay version.

Issue: #6831

Splits the bulk of pick_next_input() into a new virtual method
pick_next_input_try() which is implemented by new subclasses
scheduler_{dynamic,fixed,replay}.cpp.
Moves pick_next_input_as_previously() into the _replay version.

Issue: #6831
clients/drcachesim/scheduler/scheduler_impl.h Show resolved Hide resolved
clients/drcachesim/scheduler/scheduler_impl.h Show resolved Hide resolved
clients/drcachesim/scheduler/scheduler_impl.h Outdated Show resolved Hide resolved
clients/drcachesim/scheduler/scheduler_impl.h Outdated Show resolved Hide resolved
clients/drcachesim/scheduler/scheduler.cpp Show resolved Hide resolved
clients/drcachesim/scheduler/scheduler.cpp Show resolved Hide resolved
@derekbruening
Copy link
Contributor Author

a64 failure is api.startstop #6928

@derekbruening derekbruening merged commit 6360656 into master Nov 13, 2024
16 of 17 checks passed
@derekbruening derekbruening deleted the i6831-split-pick-next-input branch November 13, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants