Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6831 sched refactor, step 6: Split set_initial_schedule() #7082

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

derekbruening
Copy link
Contributor

Splits set_initial_schedule() into separate overrides in the 3 scheduler subclasses, sharing the initial content reading in init() prior to calling set_initial_schedule().

Splits set_output_active(): it is only valid in dynamic.

Moves rebalance_queues() and two rebalance vars to dynamic.

Moves read_recorded_schedule() and
read_and_instantiate_traced_schedule() to replay.

Adds more using statements to remove the need for "this->" prefixes on frequent base class member field references.

Issue: #6831

Splits set_initial_schedule() into separate overrides in the 3
scheduler subclasses, sharing the initial content reading in init()
prior to calling set_initial_schedule().

Splits set_output_active(): it is only valid in dynamic.

Moves rebalance_queues() and two rebalance vars to dynamic.

Moves read_recorded_schedule() and
read_and_instantiate_traced_schedule() to replay.

Adds more using statements to remove the need for "this->" prefixes on
frequent base class member field references.

Issue: #6831
clients/drcachesim/scheduler/scheduler.cpp Outdated Show resolved Hide resolved
clients/drcachesim/scheduler/scheduler_impl.h Outdated Show resolved Hide resolved
clients/drcachesim/tests/scheduler_unit_tests.cpp Outdated Show resolved Hide resolved
clients/drcachesim/scheduler/scheduler_impl.h Show resolved Hide resolved
clients/drcachesim/scheduler/scheduler.cpp Outdated Show resolved Hide resolved
clients/drcachesim/scheduler/scheduler_impl.cpp Outdated Show resolved Hide resolved
@derekbruening derekbruening merged commit 9388e31 into master Nov 14, 2024
17 checks passed
@derekbruening derekbruening deleted the i6831-split-init branch November 14, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants