i#7067 sched cpu limits: Add thread cpu footprint to schedule_stats #7095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augments schedule_stats to record how many cores each thread appears on. This is used to compute an overall histogram of cores per thread, which is a useful metric for studying migrations over time. This is done in a multi-workload-aware manner to avoid problems with duplicate thread ids across workloads. This adds new pure-virtual functions to the schedule_stats_t::histogram_t interface, so subclasses will need to be updated. Adds some multi-workload support to the testing helpers in default_memtrace_stream_t and memref_gen. Adds a unit test. Issue: #&067
derekbruening
requested review from
ivankyluk and
abhinav92003
and removed request for
ivankyluk
|
Looking like macos-12 support was dropped earlier than was documented? Xref #7055 |
abhinav92003
approved these changes
Nov 26, 2024
…ent; larger PID values in test
|
a64 is yet again the before-a-bundle assert #3320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augments schedule_stats to record how many cores each thread appears on. This is used to compute an overall histogram of cores per thread, which is a useful metric for studying migrations over time. This is done in a multi-workload-aware manner to avoid problems with duplicate thread ids across workloads.
This adds new pure-virtual functions to the
schedule_stats_t::histogram_t interface, so subclasses will need to be updated.
It also changes schedule_stats_t::counters_t.threads to use workload_tid_t rather
than just tid.
Adds some multi-workload support to the testing helpers in default_memtrace_stream_t and memref_gen.
Adds a unit test and updates existing tests.
Issue: #7067