Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dumping of custom type that mixes adapter interface #849

Merged

Conversation

andrykonchin
Copy link
Member

Fix the following case:

  • declared a field with custom type and adapter class
  • assigned a value of class that implements #dynamoid_dump method (like a simple custom type)

A proper behaviour is to use adapter's .dynamoid_dump method instead of a value's #dynamoid_dump method.

@andrykonchin andrykonchin force-pushed the ak/fix-dumping-of-custom-type-that-mixes-adapter-interface branch from 89a0854 to 1ad1959 Compare January 13, 2025 23:09
@andrykonchin andrykonchin force-pushed the ak/fix-dumping-of-custom-type-that-mixes-adapter-interface branch from 1ad1959 to 85111cf Compare January 13, 2025 23:15
Copy link

Code Coverage

Package Line Rate Health
dynamoid 92%
Summary 92% (3422 / 3735)

Minimum allowed line rate is 90%

@andrykonchin andrykonchin merged commit 4902a5c into master Jan 13, 2025
70 checks passed
@andrykonchin andrykonchin deleted the ak/fix-dumping-of-custom-type-that-mixes-adapter-interface branch January 13, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant