Automatic kubernetes api monitoring

- Removes unnecessary checks
Dynatrace · Jan 4, 2022 · 3ab6861 · 3ab6861
1 parent be7d0ef
commit 3ab6861
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 7 deletions.
diff --git a/src/controllers/activegate/reconciler/automaticapimonitoring/reconciler.go b/src/controllers/activegate/reconciler/automaticapimonitoring/reconciler.go
@@ -38,9 +38,6 @@ func (r *AutomaticApiMonitoringReconciler) Reconcile() error {
 }
 
 func (r *AutomaticApiMonitoringReconciler) ensureSettingExists() (string, error) {
-	if r.name == "" {
-		return "", errors.New("no name given")
-	}
 	if r.kubeSystemUUID == "" {
 		return "", errors.New("no kube-system namespace UUID given")
 	}

diff --git a/src/controllers/dynakube/dynakube_controller.go b/src/controllers/dynakube/dynakube_controller.go
@@ -314,7 +314,6 @@ func (r *ReconcileDynaKube) reconcileActiveGateCapabilities(dkState *status.Dyna
 
 	//start automatic config creation
 	if dkState.Instance.Status.KubeSystemUUID != "" &&
-		dkState.Instance.Name != "" &&
 		dkState.Instance.FeatureAutomaticKubernetesApiMonitoring() &&
 		dkState.Instance.KubernetesMonitoringMode() {
 		err := automaticapimonitoring.NewReconciler(dtc, dkState.Instance.Name, dkState.Instance.Status.KubeSystemUUID).

diff --git a/src/dtclient/kubernetes_settings.go b/src/dtclient/kubernetes_settings.go
@@ -69,9 +69,6 @@ type constraintViolations []struct {
 }
 
 func (dtc *dynatraceClient) CreateKubernetesSetting(name, kubeSystemUUID, scope string) (string, error) {
-	if name == "" {
-		return "", errors.New("no name given")
-	}
 	if kubeSystemUUID == "" {
 		return "", errors.New("no kube-system namespace UUID given")
 	}