Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource limits in values.yaml not correctly used. #1002

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

StefanHauth
Copy link
Collaborator

Description

The Helm chart for the CSI driver daemon set did not correctly use the values file for resource limits.
Fixed Helm chart and added Helm unit test.

How can this be tested?

  • Adopt resource limit values in the values.yaml to some arbitrary values.
  • Turn on CSI driver in values.yaml
  • Install operator via Helm using the adopted values file.
  • Check the installed daemonset manifest, Your values should be used for resource limits.

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly
  • I have read and understood the contribution guidelines

@StefanHauth StefanHauth added bug Something isn't working helm Changes to helm templates or values file labels Jul 26, 2022
@StefanHauth StefanHauth requested a review from a team as a code owner July 26, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helm Changes to helm templates or values file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants