Set empty workload kind/name on unknown owner #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0sewa0
reviewed
Aug 22, 2022
0sewa0
approved these changes
Aug 22, 2022
chrismuellner
added a commit
that referenced
this pull request
Aug 24, 2022
3 tasks
0sewa0
pushed a commit
that referenced
this pull request
Aug 24, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case of owner that is not well-known, the
kindwould be set toPod, while thenamecouldn't be set because.metadata.nameis empty at this point. The empty kind/name is correct in this case and should not block the init container.How can this be tested?
Inject into a pod that has owner reference set to something of unknown kind, i.e. not
Deployment,ReplicaSet, ..., but a separate API.Checklist