Creates the shared image dir so os.Rename can work
#1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhi-DT
reviewed
Aug 29, 2022
luhi-DT
approved these changes
Aug 29, 2022
0sewa0
added a commit
that referenced
this pull request
Aug 29, 2022
3 tasks
0sewa0
added a commit
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
/data/codemodulesdirectory is not created, and theos.Renameis not smart enough to move a dir from/data/tmp_zipto/data/codemodules/<image-digest>This causes that the CSI driver can't finish the download if
codeModulesImageis usedHow can this be tested?
Deploy the operator on a fresh cluster (where
/data/codemodulesdoesn't exist)and create a Dynakube that uses the CSI driver with
codeModulesImageChecklist