Remove constraints on ActiveGate container resources #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baichinger
approved these changes
Apr 2, 2021
DTMad
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, there is a bug when setting resources. The configuration for kubernetesMonitoring will be used for other capabilities. So customers can't set specific resource limits for the routing Pod.
Nonetheless, the current logic tries to set requests/limits within a hardcoded range. And while there is a few concerns with that (there is never a reason to reduce the limit for example), we shouldn't really be overriding customer settings unexpectedly.
I've removed this particular logic, and updated the DynaKube example to include our suggested resource requirements, but by default nothing is set. This matches the behavior of the OneAgent features.