Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only require the activeGate token scope if activeGates are used #1220

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Oct 7, 2022

The token checking logic only checked if the feature-flag is present or not, and in 0.9 it became default, so it always required it, even though you may not even want to deploy activeGates

How can this be tested?

Use a token without the activeGateTokenManagement.create scope
Deploy a dynakube without ActiveGates => should work
Deploy a dynakube with ActiveGates => should complain about the tokens

Checklist

  • [x] Unit tests have been updated/added
  • PR is labeled accordingly
  • I have read and understood the contribution guidelines

@0sewa0 0sewa0 added the bug Something isn't working label Oct 7, 2022
@0sewa0 0sewa0 requested a review from a team as a code owner October 7, 2022 08:58
@0sewa0 0sewa0 enabled auto-merge (squash) October 10, 2022 06:20
@0sewa0 0sewa0 merged commit 2fa4771 into release-0.9 Oct 10, 2022
@0sewa0 0sewa0 deleted the fix/ag-token-check branch October 10, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants