Only try create secret if not present #1222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can limit how many secrets can be created in their namespaces.
However, if that limit is reached and our namespace secret is already in the namespace, our update mechanism fails.
Because we try to create a new secret and would expect a
Already Exists
error, but in such case, we get analreadyLimit
reached error back, which crashes our logic.How can this be tested?
Example resource quota:
Use a dyankube that would inject into the namespace that has the quota. Wait for an update. Should not fail. (the secret number may change depending what you deploy 😬 )
Checklist
[ ] Unit tests have been updated/added