Update CRD caBundle if certificate secret is up to date
#1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we lower the success duration? So that if its happening we fix ourselves faster? Or would documenting that error be enough? https://github.com/Dynatrace/dynatrace-operator/pull/1240/files#diff-3c112205f7106d35079e2a488cc54f58481a8bdad2d3cf2a0aee1c05683bd2fbR22 |
luhi-DT
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the webhook certificate exists on the cluster the
caBundlefield of the CRD conversion webhook was never updated.How can this be tested?
.spec.conversion.webhook.clientConfig.caBundleCRD should be updated to include correct
caBundle!Checklist