Fixes csi-driver stuck in Terminate after restart #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhi-DT
reviewed
Oct 18, 2022
luhi-DT
approved these changes
Oct 18, 2022
chrismuellner
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CSI-driver can get stuck if it mounted volumes recently and then got restarted.
This happens due to some unexpected behaviour when using the same volume for 2 volumeMounts in a container while having
mountPropagationon both volumeMounts.Also fixes a misleading error that happens on restart.
How can this be tested?
Deploy a Dynakube that uses the CSI-driver, deploy sample apps.
After they are done deploying, restart the CSI-driver, it should restart without problem.
Checklist