Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove network zone from ActiveGate API endpoint #2114

Merged

Conversation

albertogdd
Copy link
Contributor

@albertogdd albertogdd commented Sep 13, 2023

Description

As discussed, we should not use network zone for the ActiveGate API endpoint.

How can this be tested?

  • Unit tests

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly with a single label
  • I have read and understood the contribution guidelines

@albertogdd albertogdd added the activegate Changes related to Activegate label Sep 13, 2023
@albertogdd albertogdd requested a review from a team as a code owner September 13, 2023 07:30
@albertogdd albertogdd enabled auto-merge (squash) September 13, 2023 07:33
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

Merging #2114 (51c7e4f) into main (29b5351) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #2114      +/-   ##
==========================================
- Coverage   63.24%   63.24%   -0.01%     
==========================================
  Files         242      242              
  Lines       15376    15373       -3     
==========================================
- Hits         9725     9722       -3     
  Misses       4909     4909              
  Partials      742      742              
Files Changed Coverage Δ
src/dtclient/endpoints.go 94.00% <ø> (-0.34%) ⬇️

@albertogdd albertogdd merged commit 334cbac into main Sep 13, 2023
10 checks passed
@albertogdd albertogdd deleted the refactor/remove-networkzone-from-activegate-api-endpoint branch September 13, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activegate Changes related to Activegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants