Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove specific agent version e2e test #2122

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Sep 14, 2023

Description

The specific agent version test is flaky and can be replaced with unit tests, as its main purpose is to check if the downgrade blocking logic works.

I looked at the related tests and found some minor issues that I fixed.

How can this be tested?

Run unit-tests

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly with a single label
  • I have read and understood the contribution guidelines

@0sewa0 0sewa0 added the test Changes to or additional e2e/regression tests label Sep 14, 2023
@0sewa0 0sewa0 requested a review from a team as a code owner September 14, 2023 13:29
@0sewa0 0sewa0 force-pushed the remove/specific-agent-version branch from 64e3ff4 to 2f0f458 Compare September 14, 2023 13:30
@0sewa0 0sewa0 changed the title Some fixup got the status version tests Remove specific agent version e2e test Sep 14, 2023
@0sewa0 0sewa0 enabled auto-merge (squash) September 14, 2023 13:36
@0sewa0 0sewa0 merged commit fef7cb1 into main Sep 14, 2023
10 checks passed
@0sewa0 0sewa0 deleted the remove/specific-agent-version branch September 14, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Changes to or additional e2e/regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants