Update deprecated api versions #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0sewa0
reviewed
Aug 10, 2021
| @@ -31,3 +31,20 @@ rules: | |||
| - get | |||
| - update | |||
| - delete | |||
| - apiGroups: | |||
There was a problem hiding this comment.
webhook stuff is not necessary
0sewa0
reviewed
Aug 10, 2021
| @@ -0,0 +1,11 @@ | |||
| apiVersion: kustomize.config.k8s.io/v1beta1 | |||
0sewa0
reviewed
Aug 10, 2021
| @@ -1,4 +1,4 @@ | |||
| apiVersion: admissionregistration.k8s.io/v1beta1 | |||
0sewa0
reviewed
Aug 10, 2021
| - op: add | ||
| path: /spec/template/spec/containers/0/env/- | ||
| value: | ||
| name: DISABLE_WEBHOOK |
baichinger
requested changes
Aug 10, 2021
There was a problem hiding this comment.
Should this work with the latest version of operator-sdk as well or do I need a specific one? With v1.10 it fails:
% make bundle
controller-gen "crd:trivialVersions=true, preserveUnknownFields=false, crdVersions=v1" paths="./..." output:crd:artifacts:config=config/crd/default/bases
operator-sdk generate kustomize manifests -q
WARN[0000] Config version 3-alpha has been stabilized as 3, and 3-alpha is no longer supported. Run `operator-sdk alpha config-3alpha-to-3` to upgrade your PROJECT config file to version 3
Error: error reading configuration: unable to load the configuration: unable to create config for version "3-alpha": version 3-alpha is not supported
Makefile
Outdated
Comment on lines
5
to
6
| # Default platform for bundle | ||
| PLATFORM="kubernetes" |
There was a problem hiding this comment.
This variable is still used in target bundle.
gkrenn
approved these changes
Aug 10, 2021
Fixed |
DTMad
force-pushed
the
fix/DeprecatedAPIVersions
branch
from
e2233f6
to
2154193
Compare
baichinger
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.