-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotation to exclude containers from injection. #2587
Conversation
pkg/webhook/mutation/pod_mutator/oneagent_mutation/containers.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrii Soldatenko <andrii.soldatenko@dynatrace.com>
pkg/webhook/mutation/pod_mutator/oneagent_mutation/containers.go
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2587 +/- ##
==========================================
- Coverage 65.18% 65.17% -0.02%
==========================================
Files 251 252 +1
Lines 16470 16508 +38
==========================================
+ Hits 10736 10759 +23
- Misses 4904 4915 +11
- Partials 830 834 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment below
Description
Allow to exclude containers from injection based on their names with annotations on Dynakube or pod level.
How can this be tested?
Deploy a Dynakube and an application.
Add annotation
container.inject.dynatrace.com/<containername> = false
to exclude app containers from injection.Check that code modules are not injected into containers.
Checklist