Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conditions for ActiveGate related components to Dynakube status #2923

Merged
merged 15 commits into from
Apr 9, 2024
Merged

Add conditions for ActiveGate related components to Dynakube status #2923

merged 15 commits into from
Apr 9, 2024

Conversation

gkrenn
Copy link
Contributor

@gkrenn gkrenn commented Mar 25, 2024

Description

In order to be more expressive what's going on inside the operator, conditions for the ActiveGate are added to the dynakube status.

How can this be tested?

  • Run a dynakube with ActiveGate and check if the conditions are there

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly with a single label
  • I have read and understood the contribution guidelines

@gkrenn gkrenn added the activegate Changes related to Activegate label Mar 25, 2024
@gkrenn gkrenn requested a review from a team as a code owner March 25, 2024 15:11
0sewa0
0sewa0 requested changes Mar 26, 2024
View reviewed changes
pkg/api/v1beta1/dynakube/dynakube_conditions.go Outdated Show resolved Hide resolved
pkg/api/v1beta1/dynakube/dynakube_conditions.go Outdated Show resolved Hide resolved
@gkrenn gkrenn force-pushed the feature/add-activegate-conditions branch from 6a44cb6 to d66cbb8 Compare March 26, 2024 12:21
@gkrenn gkrenn marked this pull request as draft March 26, 2024 15:07
@0sewa0 0sewa0 mentioned this pull request Mar 28, 2024
Merged
3 tasks
@gkrenn gkrenn force-pushed the feature/add-activegate-conditions branch from d66cbb8 to 7c8aae6 Compare April 2, 2024 17:53
@gkrenn
Copy link
Contributor Author

gkrenn commented Apr 2, 2024

Updated to match PR #2910

@gkrenn gkrenn marked this pull request as ready for review April 2, 2024 18:17
@gkrenn gkrenn requested a review from 0sewa0 April 2, 2024 18:17
@gkrenn
Merge branch 'main' into feature/add-activegate-conditions
dc626c5 
# Conflicts:
#	pkg/controllers/dynakube/connectioninfo/activegate/reconciler.go
#	pkg/controllers/dynakube/connectioninfo/activegate/reconciler_test.go
#	pkg/controllers/dynakube/version/activegate.go
@gkrenn
Remove last request field from status
677682b
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.31250% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 67.01%. Comparing base (f25531b) to head (6967e9d).

Files Patch % Lines
pkg/util/conditions/statefulset.go 0.00% 28 Missing ⚠️
...s/dynakube/connectioninfo/activegate/reconciler.go 35.71% 6 Missing and 3 partials ⚠️
...kube/activegate/internal/statefulset/reconciler.go 57.14% 2 Missing and 4 partials ⚠️
pkg/util/conditions/suffix.go 25.00% 6 Missing ⚠️
pkg/api/v1beta1/dynakube/zz_generated.deepcopy.go 0.00% 4 Missing ⚠️
pkg/controllers/dynakube/version/activegate.go 78.94% 2 Missing and 2 partials ⚠️
pkg/util/conditions/error.go 0.00% 3 Missing and 1 partial ⚠️
...llers/dynakube/activegate/capability/capability.go 88.88% 2 Missing ⚠️
...nakube/activegate/internal/authtoken/reconciler.go 0.00% 1 Missing and 1 partial ⚠️
pkg/controllers/dynakube/istio/reconciler.go 0.00% 1 Missing and 1 partial ⚠️
... and 2 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2923      +/-   ##
==========================================
- Coverage   67.21%   67.01%   -0.20%     
==========================================
  Files         263      265       +2     
  Lines       14352    14431      +79     
==========================================
+ Hits         9646     9671      +25     
- Misses       3869     3919      +50     
- Partials      837      841       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

0sewa0
0sewa0 requested changes Apr 8, 2024
View reviewed changes
pkg/util/conditions/suffix.go Outdated Show resolved Hide resolved
pkg/controllers/dynakube/activegate/internal/statefulset/reconciler.go Outdated Show resolved Hide resolved
@gkrenn gkrenn requested a review from 0sewa0 April 8, 2024 15:25
waodim
waodim previously approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@waodim waodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving as I think the code LGTM and you have adressed all of @0sewa0 points.

@gkrenn gkrenn requested review from 0sewa0 and waodim April 9, 2024 11:25
@gkrenn gkrenn merged commit cd9716e into main Apr 9, 2024
17 checks passed
@gkrenn gkrenn deleted the feature/add-activegate-conditions branch April 9, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0sewa0 0sewa0 0sewa0 approved these changes

@waodim waodim waodim approved these changes

@chrismuellner chrismuellner Awaiting requested review from chrismuellner chrismuellner is a code owner automatically assigned from Dynatrace/kubernetes-operator

@albertogdd albertogdd Awaiting requested review from albertogdd albertogdd is a code owner automatically assigned from Dynatrace/kubernetes-operator

@StefanHauth StefanHauth Awaiting requested review from StefanHauth StefanHauth is a code owner automatically assigned from Dynatrace/kubernetes-operator

@aorcholski aorcholski Awaiting requested review from aorcholski aorcholski is a code owner automatically assigned from Dynatrace/kubernetes-operator

@luhi-DT luhi-DT Awaiting requested review from luhi-DT luhi-DT is a code owner automatically assigned from Dynatrace/kubernetes-operator

Assignees
No one assigned
Labels
activegate Changes related to Activegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gkrenn @codecov-commenter @0sewa0 @waodim