Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rules to permission script and remove outdated permission #2992

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

chrismuellner
Copy link
Collaborator

Description

Updated script that generates the permission table for our components to be compatible with newly added rules:

  • Add mapping for Activegate and Edgeconnect

⚠️ Remove Activegate CR permission from Operator cluster role (not used).

How can this be tested?

Verify markdown permission table is correctly generated:

  1. Run make doc/permission
  2. Verify that permissions.md created in project directory is there and correct

If there are missing python packages run the following command (thanks @gkrenn )

pip3 install -r hack/requirements.txt

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly with a single label
  • I have read and understood the contribution guidelines

@chrismuellner chrismuellner added the documentation Improvements or additions to documentation label Apr 9, 2024
@chrismuellner chrismuellner requested a review from a team as a code owner April 9, 2024 16:23
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.00%. Comparing base (4976d7a) to head (cdd9b41).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2992   +/-   ##
=======================================
  Coverage   67.00%   67.00%           
=======================================
  Files         265      265           
  Lines       14445    14445           
=======================================
  Hits         9679     9679           
  Misses       3924     3924           
  Partials      842      842           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrismuellner chrismuellner merged commit 756a221 into main Apr 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants