Fix container-name and container-image env var counter if container is excluded via annotation #3007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhi-DT
requested review from
gkrenn,
0sewa0,
chrismuellner,
albertogdd,
waodim,
StefanHauth and
aorcholski
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-1.1 #3007 +/- ##
============================================
Coverage 67.00% 67.00%
============================================
Files 265 265
Lines 14445 14445
============================================
Hits 9679 9679
Misses 3924 3924
Partials 842 842 ☔ View full report in Codecov by Sentry. |
gkrenn
approved these changes
Apr 16, 2024
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
Currently the initContainer of an injected Pod fails, if there is a second container in the list of containers, which is excluded and in-front of the monitored container, in the list of containers.
How can this be tested?
Deploy Operator -> cloudNativeFullStack -> create a sample pod with 2 containers -> exclude the first container in the list of containers from monitoring via annotation on Dynakube
container.inject.dynatrace.com/<container name to exclude>: "false"(important, it has to be the first one)