New data-ingest endpoint secret containing data-ingest URL and token mounted to micrometer pods #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aorcholski
force-pushed
the
feature/webhook-endpoint-secret
branch
from
c426a73
to
6dba681
Compare
aorcholski
force-pushed
the
feature/webhook-endpoint-secret
branch
from
6dba681
to
925d3b6
Compare
0sewa0
reviewed
Nov 10, 2021
chrismuellner
requested changes
Nov 10, 2021
match two or more Dynakubes regarding app injection) data-ingest url and token also injected as environment variables init.sh secret is not recreated every few seconds
aorcholski
force-pushed
the
feature/webhook-endpoint-secret
branch
from
85169e8
to
4f5e8d8
Compare
chrismuellner
requested changes
Nov 16, 2021
chrismuellner
previously approved these changes
Nov 16, 2021
webhook doesn't crash if dataIngestToken doesn't exist
aorcholski
force-pushed
the
feature/webhook-endpoint-secret
branch
from
bfa36f6
to
a3890d0
Compare
chrismuellner
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
single data-ingest endpoint secret per namespace (namespace can not match two or more Dynakubes regarding app injection)
init.sh secret is not recreated every few seconds