Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct metadata-enrichment annotation prefix #3273

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Jun 10, 2024

Description

metrics-enrichment is not a thing, its metadata-enrichment 😅

How can this be tested?

play around with the annotations

@0sewa0 0sewa0 added the bug Something isn't working label Jun 10, 2024
@0sewa0 0sewa0 requested a review from a team as a code owner June 10, 2024 14:19
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.83%. Comparing base (01acf25) to head (390f2db).

Current head 390f2db differs from pull request most recent head 3886bda

Please upload reports for the commit 3886bda to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3273   +/-   ##
=======================================
  Coverage   58.83%   58.83%           
=======================================
  Files         326      326           
  Lines       18180    18180           
=======================================
  Hits        10696    10696           
  Misses       6285     6285           
  Partials     1199     1199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0sewa0 0sewa0 enabled auto-merge (squash) June 12, 2024 07:20
@0sewa0 0sewa0 merged commit 6e11a3d into main Jun 12, 2024
14 checks passed
@0sewa0 0sewa0 deleted the fix/metadata-enrichment-naming branch June 12, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants