Change bracket type for labels and annotations in values.yaml #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhi-DT
requested review from
gkrenn,
0sewa0,
chrismuellner,
albertogdd,
waodim,
StefanHauth and
wepudt
luhi-DT
changed the title
0sewa0
approved these changes
Jul 4, 2024
waodim
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://dt-rnd.atlassian.net/browse/K8S-10499
Adding a label using an umbrella helm chart that has the operator helm chart as a child. Due to labels being initalized as an array with labels: [] in values.yaml, this causes an error when you try to override it.
coalesce.go:289: warning: destination for dynatrace-operator-azure-app.dynatrace-operator.operator.labels is a table. Ignoring non-table value ([])There are many github issues where other charts did this and they got corrected - cert-manager is an example where they do this correctly: cert-manager/deploy/charts/cert-manager/values.yaml at master · cert-manager/cert-manager
How can this be tested?
Apply the helm chart with default values and check if it works still
Apply the helm chart with custom values set for annotations and labels in the values file