Add Verification of OneAgent Version #3405
Merged
+55
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wepudt
requested review from
gkrenn,
0sewa0,
chrismuellner,
albertogdd,
waodim,
StefanHauth and
aorcholski
0sewa0
reviewed
Jul 4, 2024
wepudt
changed the title
aorcholski
reviewed
Jul 4, 2024
luhi-DT
reviewed
Jul 5, 2024
aorcholski
force-pushed
the
feature/verify_oneagent_version_is_semver
branch
4 times, most recently
from
fa49a41
to
59b5230
Compare
aorcholski
force-pushed
the
feature/verify_oneagent_version_is_semver
branch
from
59b5230
to
6cfc3e4
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3405 +/- ##
==========================================
+ Coverage 57.23% 57.25% +0.01%
==========================================
Files 344 344
Lines 19783 19791 +8
==========================================
+ Hits 11323 11331 +8
Misses 7222 7222
Partials 1238 1238
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
luhi-DT
approved these changes
Jul 12, 2024
StefanHauth
pushed a commit
that referenced
this pull request
Jul 12, 2024
Co-authored-by: adam.orcholski <adam.orcholski@dynatrace.com>
StefanHauth
added a commit
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see K8S-10190
Description
The operator should reject OneAgent versions that are not conformant to major.minor.patch pattern subset of SemVer. e.g. 1.0.0
How can this be tested?
Apply a DK with OneAgent version set to an invalid version such as
latest,rawor1.296.0-rawand to a valid one such as 1.296.0