Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShortNames for EdgeConnect CRs #3409

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

wepudt
Copy link
Collaborator

@wepudt wepudt commented Jul 4, 2024

see K8S-9651

Description

Add shortnames ec, ecs to EdgeConnect CRD.

kubectl get ec -n dynatrace should return EdgeConnect CRs.

How can this be tested?

make manifests/crd/install
kubectl get ec -n dynatrace

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.32%. Comparing base (9d63386) to head (468a809).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3409   +/-   ##
=======================================
  Coverage   58.32%   58.32%           
=======================================
  Files         333      333           
  Lines       18661    18661           
=======================================
  Hits        10884    10884           
  Misses       6558     6558           
  Partials     1219     1219           
Flag Coverage Δ
unittests 58.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wepudt wepudt changed the title Reduce Parallel Execution of E2E Tests to Improve Stability Add ShortNames for EdgeConnect CRs Jul 4, 2024
@wepudt wepudt marked this pull request as ready for review July 4, 2024 10:39
@wepudt wepudt requested a review from a team as a code owner July 4, 2024 10:39
albertogdd
albertogdd previously approved these changes Jul 4, 2024
Copy link
Collaborator

@StefanHauth StefanHauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it, LGTM

@wepudt wepudt force-pushed the feature/edgeconnect_shortnames branch from dd847d5 to 42cf094 Compare July 4, 2024 14:09
@wepudt wepudt force-pushed the feature/edgeconnect_shortnames branch from 42cf094 to e5d48a9 Compare July 4, 2024 14:10
@wepudt wepudt enabled auto-merge (squash) July 4, 2024 14:10
@wepudt wepudt requested a review from 0sewa0 July 4, 2024 14:11
@wepudt wepudt merged commit 32a4011 into main Jul 8, 2024
13 checks passed
@wepudt wepudt deleted the feature/edgeconnect_shortnames branch July 8, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants