-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make kubeobject utils more generic #3425
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3425 +/- ##
==========================================
- Coverage 58.05% 57.77% -0.28%
==========================================
Files 365 371 +6
Lines 20316 20162 -154
==========================================
- Hits 11794 11649 -145
- Misses 7269 7277 +8
+ Partials 1253 1236 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
46c168d
to
7eac4b6
Compare
convert it back to draft, forgot about the owner-reference 😅 |
pkg/controllers/dynakube/activegate/internal/customproperties/reconciler.go
Outdated
Show resolved
Hide resolved
49cbd7e
to
644d503
Compare
d3459df
to
159d69c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with simple cloudnative deployment, everything alright 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works well in my cluster, especially with both EC setups.
Description
K8S-9483
Basic idea is to have the same interface for interacting with the kube-api, as we have multiple ways of doing it.
Changes: (the commits are semi-nicely structured)
Modifier
/Builder
interface in thekubeobjects
, as it was overkill and made a simpler oneQuery
struct with a generic implementation that is reusable for everyclient.Object
Query
objects usagesSidenote:
kubeobjects
could use some loveHow can this be tested?
No change in behaviour