-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile Extensions Secret with EEC Token #3426
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3426 +/- ##
==========================================
+ Coverage 57.23% 57.31% +0.07%
==========================================
Files 344 346 +2
Lines 19781 19834 +53
==========================================
+ Hits 11322 11367 +45
- Misses 7221 7226 +5
- Partials 1238 1241 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
return err | ||
} | ||
|
||
if errors.IsNotFound(err) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we not checking if the existing secret contains what we expect it to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK we generate its content (the eec-token) and we can't validate it against the API for now, but I will talk with the team about it.
Co-authored-by: Christoph Muellner <33160506+chrismuellner@users.noreply.github.com>
Closing PR because of merge conflicts. New PR here #3485 |
Description
K8S-10120
New extensions secret is reconciled when
dynakube.spec.extensions.prometheus.enabled = true
Secret name =
<dk-name>-extensions-token
, containingeec-token
data, which gets generated only once.New conditions added related to the secret creation
How can this be tested?
dynakube.spec.extensions.prometheus.enabled = true