Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reconcile interval incase of an error when updating the agent in the provsioner (#3429) #3442

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

luhi-DT
Copy link
Collaborator

@luhi-DT luhi-DT commented Jul 11, 2024

Description

Same as in #3429

How can this be tested?

Same as in #3429

@luhi-DT luhi-DT added the cherrypick Cherrypicked changes that already exist in a different PR label Jul 11, 2024
@luhi-DT luhi-DT requested a review from a team as a code owner July 11, 2024 06:54
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.23%. Comparing base (691a678) to head (0faa9be).

Files Patch % Lines
pkg/controllers/csi/provisioner/controller.go 50.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3442      +/-   ##
==========================================
- Coverage   57.23%   57.23%   -0.01%     
==========================================
  Files         344      344              
  Lines       19781    19783       +2     
==========================================
+ Hits        11322    11323       +1     
- Misses       7221     7222       +1     
  Partials     1238     1238              
Flag Coverage Δ
unittests 57.23% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luhi-DT luhi-DT enabled auto-merge (squash) July 11, 2024 12:19
@luhi-DT luhi-DT merged commit 0190b98 into main Jul 11, 2024
14 checks passed
@luhi-DT luhi-DT deleted the fix/reqeue-interval-for-csi-driver branch July 11, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick Cherrypicked changes that already exist in a different PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants