-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add monitored entity reconciler #3447
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3447 +/- ##
==========================================
- Coverage 57.77% 57.71% -0.06%
==========================================
Files 371 372 +1
Lines 20162 20181 +19
==========================================
- Hits 11649 11648 -1
- Misses 7277 7290 +13
- Partials 1236 1243 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
config/helm/chart/default/templates/Common/crd/dynatrace-operator-crd.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 final nitpick, otherwise looks good, tested it and works as expected (noticed the nitpick during the tests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 final nitpick, otherwise looks good, tested it and works as expected (noticed the nitpick during the tests)
CRD needs to be regenerated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
With this a new reconciler is added that deals with the monitored entity from the cluster. It will be stored in the dynakube status from now on, such that if we need to store the value we can guarantee that it is stored somewhere.
Because of this I removed the API call which was inside the settings enrichment reconciler, as it is unneeded as the main purpose was to get the entityID. From now on the ID is simply taken from the dynakube status.
JIRA-ticket: https://dt-rnd.atlassian.net/browse/K8S-9857
How can this be tested?
Deploy the operator and a dynakube with metadata enrichment enabled. Check the logs, also check the dynakube status.