Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all imports of the CRs we use #3451

Merged
merged 13 commits into from
Jul 12, 2024
Merged

Conversation

andriisoldatenko
Copy link
Contributor

@andriisoldatenko andriisoldatenko commented Jul 11, 2024

Description

This PR implements groundwork for a consistent way of importing the API-packages of our CRs in a way that if we bump the version, there will be a minimal amount of changes necessary.

How can this be tested?

make go/test
run some basic e2e tests to install dynakube/edgeconnect.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.82755% with 143 lines in your changes missing coverage. Please review.

Project coverage is 57.25%. Comparing base (bec4ad4) to head (b484c00).

Files Patch % Lines
pkg/controllers/edgeconnect/controller.go 83.20% 12 Missing and 10 partials ⚠️
...kg/controllers/dynakube/dynatraceclient/builder.go 31.81% 15 Missing ⚠️
cmd/troubleshoot/builder.go 36.36% 14 Missing ⚠️
cmd/troubleshoot/dynakube.go 57.14% 12 Missing ⚠️
...s/dynakube/processmoduleconfigsecret/reconciler.go 64.28% 9 Missing and 1 partial ⚠️
...nakube/activegate/internal/authtoken/reconciler.go 52.94% 7 Missing and 1 partial ⚠️
cmd/troubleshoot/image.go 22.22% 6 Missing and 1 partial ⚠️
...ntrollers/dynakube/oneagent/oneagent_reconciler.go 87.71% 6 Missing and 1 partial ⚠️
pkg/controllers/dynakube/conditions.go 71.42% 3 Missing and 3 partials ⚠️
...s/dynakube/connectioninfo/activegate/reconciler.go 68.42% 4 Missing and 2 partials ⚠️
... and 21 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3451   +/-   ##
=======================================
  Coverage   57.25%   57.25%           
=======================================
  Files         344      344           
  Lines       19791    19791           
=======================================
  Hits        11331    11331           
  Misses       7222     7222           
  Partials     1238     1238           
Flag Coverage Δ
unittests 57.25% <85.82%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/troubleshoot/dynakube_test.go Outdated Show resolved Hide resolved
cmd/troubleshoot/dynakube_test.go Outdated Show resolved Hide resolved
cmd/troubleshoot/dynakube_test.go Outdated Show resolved Hide resolved
@andriisoldatenko andriisoldatenko changed the title try 1: Change all imports of the CRs we use Change all imports of the CRs we use Jul 11, 2024
@andriisoldatenko andriisoldatenko marked this pull request as ready for review July 11, 2024 18:40
@andriisoldatenko andriisoldatenko requested a review from a team as a code owner July 11, 2024 18:40
pkg/controllers/edgeconnect/deployment/deployment_test.go Outdated Show resolved Hide resolved
pkg/controllers/edgeconnect/secret/secret.go Outdated Show resolved Hide resolved
pkg/controllers/edgeconnect/version/reconciler.go Outdated Show resolved Hide resolved
pkg/controllers/edgeconnect/version/updater.go Outdated Show resolved Hide resolved
test/helpers/components/edgeconnect/edgeconnect.go Outdated Show resolved Hide resolved
pkg/controllers/edgeconnect/controller.go Outdated Show resolved Hide resolved
pkg/controllers/edgeconnect/controller.go Outdated Show resolved Hide resolved
pkg/controllers/edgeconnect/controller.go Outdated Show resolved Hide resolved
pkg/controllers/edgeconnect/controller.go Outdated Show resolved Hide resolved
Copy link
Contributor

@aorcholski aorcholski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO
cmd/webhook/builder.go
pkg/controlles/dynakube/controller.go
pkg/controlles/dynakub/extension/reconciler.go
test/helper/components/dynakube/dynakube.go dynatracev1beta1->v1beta1?
test/helper/components/oneagent/daemonset.go
doc/e2e/features.md

@andriisoldatenko
Copy link
Contributor Author

TODO cmd/webhook/builder.go pkg/controlles/dynakube/controller.go pkg/controlles/dynakub/extension/reconciler.go test/helper/components/dynakube/dynakube.go dynatracev1beta1->v1beta1? test/helper/components/oneagent/daemonset.go doc/e2e/features.md

fixed in b5bc53c

pkg/controllers/csi/provisioner/events.go Outdated Show resolved Hide resolved
pkg/controllers/dynakube/activegate/reconciler.go Outdated Show resolved Hide resolved
pkg/controllers/dynakube/activegate/reconciler_test.go Outdated Show resolved Hide resolved
pkg/controllers/dynakube/activegate/reconciler_test.go Outdated Show resolved Hide resolved
pkg/controllers/dynakube/activegate/reconciler_test.go Outdated Show resolved Hide resolved
pkg/controllers/dynakube/activegate/reconciler_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@aorcholski aorcholski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some function parameter names and variable names to be renamed
can be found using the following search patterns:

  • \(dynakube - (dynakube<space>
  • dynakube - <space>dynakube<space>

@aorcholski aorcholski self-requested a review July 12, 2024 10:45
@andriisoldatenko
Copy link
Contributor Author

andriisoldatenko commented Jul 12, 2024

  • dynakube

fixed in 1f27779 and in 360cb88 and in d98fc4e

@albertogdd
Copy link
Contributor

Running E2E tests, so far so good

@andriisoldatenko andriisoldatenko enabled auto-merge (squash) July 12, 2024 14:06
@andriisoldatenko andriisoldatenko merged commit 7677e1f into main Jul 12, 2024
19 checks passed
@andriisoldatenko andriisoldatenko deleted the change-all-imports-of-crs branch July 12, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants