-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change all imports of the CRs we use #3451
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3451 +/- ##
=======================================
Coverage 57.25% 57.25%
=======================================
Files 344 344
Lines 19791 19791
=======================================
Hits 11331 11331
Misses 7222 7222
Partials 1238 1238
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pkg/controllers/dynakube/activegate/capability/capability_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
cmd/webhook/builder.go
pkg/controlles/dynakube/controller.go
pkg/controlles/dynakub/extension/reconciler.go
test/helper/components/dynakube/dynakube.go dynatracev1beta1->v1beta1?
test/helper/components/oneagent/daemonset.go
doc/e2e/features.md
fixed in b5bc53c |
pkg/controllers/dynakube/activegate/internal/capability/reconciler.go
Outdated
Show resolved
Hide resolved
pkg/controllers/dynakube/activegate/internal/customproperties/reconciler.go
Outdated
Show resolved
Hide resolved
pkg/controllers/dynakube/activegate/internal/customproperties/reconciler.go
Outdated
Show resolved
Hide resolved
pkg/controllers/dynakube/activegate/internal/customproperties/reconciler_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some function parameter names and variable names to be renamed
can be found using the following search patterns:
\(dynakube
- (dynakube<space>dynakube
- <space>dynakube<space>
Running E2E tests, so far so good |
Description
This PR implements groundwork for a consistent way of importing the API-packages of our CRs in a way that if we bump the version, there will be a minimal amount of changes necessary.
How can this be tested?
make go/test
run some basic e2e tests to install dynakube/edgeconnect.