Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ondemand E2E slack message #3458

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

albertogdd
Copy link
Contributor

Description

Default mode (main branch) prints an empty branch value. This fixes it.

image

How can this be tested?

There is no need; it's exactly the same in the working workflow e2e-tests.yaml.

@albertogdd albertogdd added the bug Something isn't working label Jul 12, 2024
@albertogdd albertogdd requested a review from a team as a code owner July 12, 2024 11:52
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.25%. Comparing base (06029bb) to head (d544ef3).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3458      +/-   ##
==========================================
+ Coverage   57.23%   57.25%   +0.01%     
==========================================
  Files         344      344              
  Lines       19783    19791       +8     
==========================================
+ Hits        11323    11331       +8     
  Misses       7222     7222              
  Partials     1238     1238              
Flag Coverage Δ
unittests 57.25% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertogdd albertogdd enabled auto-merge (squash) July 12, 2024 12:31
@albertogdd albertogdd merged commit bec4ad4 into main Jul 12, 2024
14 checks passed
@albertogdd albertogdd deleted the fix/ondemand-e2e-slack-message branch July 12, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants