-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change stored version to v1beta3 #3463
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3463 +/- ##
==========================================
+ Coverage 57.28% 57.68% +0.39%
==========================================
Files 344 354 +10
Lines 19796 20006 +210
==========================================
+ Hits 11340 11540 +200
- Misses 7216 7226 +10
Partials 1240 1240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a partial review, didn't check everything yet
Checked all files, no further comments
config/helm/chart/default/templates/Common/webhook/validatingwebhookconfiguration.yaml
Outdated
Show resolved
Hide resolved
a8e981e
to
39ed827
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested scenarios: (all cloudnative)
- Upgrade from
main
with a previous DynaKube present - Apply v1beta2 DynaKube
- Apply v1beta3 DynaKube
Description
This PR has all changes requires to use stored version as
v1beta3
including:"github.com/Dynatrace/dynatrace-operator/pkg/api/v1beta2/dynakube"
to"github.com/Dynatrace/dynatrace-operator/pkg/api/v1beta3/dynakube"
mostly everywhere, except few files;v1beta3
package;How can this be tested?
Make sure we store every CR (dynakube) using
v1beta3
, some testing ideas:dynakube v1beta1
-> stored asv1beta3
dynakube v1beta2
-> stored asv1beta3
dynakube v1beta3
-> stored asv1beta3
Optional:
dynakube v1beta2
, and then upgrade the operator using this PR.